014: Zen and the Art of Pull Requests

Working Code

Ben has "feelings" about many aspects of web application development. And, after working with git and GitHub for the last 10-years, he's formed a lot of strong opinions - oftentimes strongly held - about how Pull Requests (PRs) should be created and managed within a team context. For example:

Code completed is more important than code being written. As such, if an open PR sits around for more than an hour, your team has failed to review said PR in a timely manner.

And:

If a PR takes more than 15-minutes to review, the PR is too large. The author of said PR has failed to decompose the problem into smaller, independently-deployable changes.

As you can imagine, Ben's "PR Commandments" don't work for every one or every team. This week, the crew meets to discuss his approach to Pull Requests, reaching consensus on some concepts and pushing-back strongly on others. And, of course, this is totally fine - every team has its own set of constraints that have bearing on how that team operates. Your mileage my vary!

Plus, we find out that Carol can be bribed with tacos... sweet, sweet tacos!

Triumphs & Failures

• Adam's Triumph - He just had his 9-year work anniversary at AlumnIQ! And, as he reflects on the last 9-years, he's amazed to realize that he never wanted to quit. Every day seems to be a stream of challenges; which is exactly what makes the work so invigorating! When he thinks back to prior jobs that he has quit, they were always boring jobs building "forms over data" type products. He's looking forward to the next 9-years!
• Ben's Triumph - He gets a little nostalgic this week, recalling a thought he had 15-years ago about how amazing it would be to create a software system that worked like the human body, with cells that acted independently and communicated via hormones. At the time, he dismissed the thought as being crazy; but, fast-forward to today, it turns out that his instincts were actually spot-on. Though, instead of hormones, we have event-streams, message queues, and pub-sub mechanism; and, instead of cells, we have distributed, independently-scalable systems that are kept up-to-date through "eventually consistent" communications!
• Carol's Triumph - Her team has moved all thirteen of their pending-work branches into testing. This is the culmination of weeks of hard work. And, to top it off, she's proud of the fact that she was able to buckle-down and maintain a high standard of quality for her coding all the way to the very end! No cutting corners for this engineer!
• Tim's Triumph - He was required to participate in a coaching and mentoring workshop at his company. And, though he was initially frustrated about having to put pressing-work-matters on hold, once the workshop started, he found it be quite helpful. And, he was even able to find the solution to a problem he's been wrestling with for some time! It turns out that if you open yourself up to opportunities in front of you, you never know what you're gonna find!

Notes & Links

• git - the most popular source-control system on planet earth.
• GitHub - a very popular source-control solution, built on git.
• BitBucket - another popular source-control solution from Atlassian.

Follow the show! Our website is workingcode.dev and we're @WorkingCodePod on Twitter and Instagram. New episodes weekly on Wednesday.

And, if you're feeling the love, support us on Patreon.